Update StoreRegistry to dynamically load clustering classes#1005
Merged
dsoumis merged 3 commits intoMay 12, 2026
Conversation
dsoumis
reviewed
May 11, 2026
dsoumis
reviewed
May 11, 2026
Contributor
|
Too bad we have to add that complexity, but I guess the clustering is optional elsewhere, so ok. |
Update StoreRegistry to use lazy initialization with dynamic class loading for optional clustering interfaces, preventing NoClassDefFoundError when StoreConfigLifecycleListener is configured but clustering classes are unavailable. This change aligns StoreConfig behavior with other Tomcat components like Catalina.addClusterRuleSet() which already handle optional clustering gracefully via reflection. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
… clustering installations where catalina-ha.jar is present but catalina-tribes.jar is not.
8dc63e1 to
3b7883e
Compare
dsoumis
added a commit
that referenced
this pull request
May 12, 2026
* Fix StoreRegistry to dynamically load clustering classes Update StoreRegistry to use lazy initialization with dynamic class loading for optional clustering interfaces, preventing NoClassDefFoundError when StoreConfigLifecycleListener is configured but clustering classes are unavailable. This change aligns StoreConfig behavior with other Tomcat components like Catalina.addClusterRuleSet() which already handle optional clustering gracefully via reflection. * Catch NoClassDefFoundError in StoreRegistry.tryAddClass() for partial clustering installations where catalina-ha.jar is present but catalina-tribes.jar is not. --------- Co-authored-by: Dimitris Soumis <jimsoumis@gmail.com>
dsoumis
added a commit
that referenced
this pull request
May 12, 2026
* Fix StoreRegistry to dynamically load clustering classes Update StoreRegistry to use lazy initialization with dynamic class loading for optional clustering interfaces, preventing NoClassDefFoundError when StoreConfigLifecycleListener is configured but clustering classes are unavailable. This change aligns StoreConfig behavior with other Tomcat components like Catalina.addClusterRuleSet() which already handle optional clustering gracefully via reflection. * Catch NoClassDefFoundError in StoreRegistry.tryAddClass() for partial clustering installations where catalina-ha.jar is present but catalina-tribes.jar is not. --------- Co-authored-by: Dimitris Soumis <jimsoumis@gmail.com>
dsoumis
added a commit
that referenced
this pull request
May 12, 2026
* Fix StoreRegistry to dynamically load clustering classes Update StoreRegistry to use lazy initialization with dynamic class loading for optional clustering interfaces, preventing NoClassDefFoundError when StoreConfigLifecycleListener is configured but clustering classes are unavailable. This change aligns StoreConfig behavior with other Tomcat components like Catalina.addClusterRuleSet() which already handle optional clustering gracefully via reflection. * Catch NoClassDefFoundError in StoreRegistry.tryAddClass() for partial clustering installations where catalina-ha.jar is present but catalina-tribes.jar is not. --------- Co-authored-by: Dimitris Soumis <jimsoumis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that if you use the StoreConfigListener but tomcat doesn't have the clustering JARs available that it prevents tomcat from starting successfully. The StoreConfigListener had hard dependencies on the clustering libraries, so I made those dynamic. Also added a few tests to make sure the reflection is working as expected.